fix: address post-merge review findings (JSON stdout purity, branch slug collisions, dedupe over-collapse)#59
Merged
Conversation
1. up/down/restart --json route compose subprocess stdout to stderr so stdout stays a single parseable envelope (shell.run gains fd-2 routing; threaded through the compose backend and all four lifecycle call sites). 2. Auto branch slugs are collision-resistant: when two linked worktrees' branches sanitize to the same slug (feature/api vs feature-api), both deterministically get a short raw-name hash suffix instead of silently sharing one branch instance. 3. Per-package dedupe groups by (package, script suffix): distinct dev:web/dev:api scripts in a single-package repo are distinct services and all survive; only same-service variants collapse. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
roodboi
pushed a commit
that referenced
this pull request
Jul 8, 2026
There was a problem hiding this comment.
💡 Codex Review
Line 168 in 11f5788
Escape the separator instead of embedding a NUL byte
This template literal contains an actual NUL byte between packageId and suffix. That makes Git classify src/init/validation.ts as binary in this commit, so future reviews, merges, and text-processing tools lose normal line diffs even though this is TypeScript. Use an escaped separator such as \0 or a printable delimiter instead.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep of review comments that arrived after PRs #54/#58 merged:
--json, so progress lines could precede the envelope.run()can now route child stdout to fd 2; wired through the backend and all lifecycle call sites. Plumbing pinned by tests.feature/apiandfeature-apisanitize identically — two worktrees would share one branch instance and could stop each other's containers. Colliding slugs now get a deterministic 4-hex raw-name suffix on both sides; non-colliding slugs unchanged. Tested with a real two-worktree fixture including stability across invocations.dev:web/dev:apiscripts lost all but one service. Dedupe now groups by (package, script suffix) so distinct services survive and only same-service variants (dev/start/serve/watch) collapse.Full suite 811/0, e2e green.
🤖 Generated with Claude Code